FUNCTION_NAME macro treated as variable

[hauleth]

I am trying to write Mix task for Elvis unfortunately when some macro tries to use other macro twice it do not expand them and it results in treating FUNCTION_NAME as variable instead of macro, which in the end makes variable_naming_convention fails.

[aboroska]

I had the same issue. (embedded macros) The quick workaround was to add the following style rule to my elvis.config

rules => [
  {elvis_style, variable_naming_convention,
                  #{regex => "^_?([_A-Z][0-9a-zA-Z]*)$|^FUNCTION_NAME$"}}
]

[hauleth]

@aboroska this isn't the only macro that would fail. TBH I think that any predefined macro will also fail as FUNCTION_ARITY also fires the error.

[hauleth]

@igaray it is worth mentioning that it happens me only if I run Elvis installed via Mix, when I am using Elvis via Rebar3 then everything works as expected. So maybe issue is with dependency resolution? I will try to investigate further.

[hauleth]

Ok, it fails with rebar3 lint as well. I cannot find any solution, only workarounds.

[jfacorro]

There's a new version of elvis_core that should solve this issue and be able to detect macros, regardless of their names and usage.

[hauleth]

@jfacorro you mean elvis_core 0.4.3? This release still has that problem, however on master it seems to be resolved.

[jfacorro]

@hauleth Yes, sorry. It is the current master, but I was about to cut a new release and then didn't. The next 0.5.0 release will include the fix.

[jfacorro]

@hauleth There is now a new 0.5.0 release for elvis_core. We will shortly bump it in elvis.