Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The way globs in elvis.config are interpreted generates duplicated analysis of files #508

Closed
elbrujohalcon opened this issue Sep 5, 2019 · 3 comments
Closed

The way globs in elvis.config are interpreted generates duplicated analysis of files #508

elbrujohalcon opened this issue Sep 5, 2019 · 3 comments
Labels
bug

Comments

@elbrujohalcon
Copy link
Member

Even after inaka/elvis_core#111, we still have certain conditions in which we analyze some files twice.
To replicate the issue, build a project with the following subfolders:

  • src
    • m1.erl
    • sub1
      • m2.erl
      • sub3
        • m3.erl

You can try with the following values for dirs:

  • ["src/**"]: that won't analyze m1.erl.
  • ["src", "src/**"]: that will analyze each module twice.
  • ["src", "src/*", "src/*/*"]: that will analyze m1.erl once, m2.erl twice and m3.erl three times.
jfacorro referenced this issue in inaka/elvis_core Nov 26, 2019
Prevent duplicate linting of files
1d80b28
@elbrujohalcon elbrujohalcon mentioned this issue Sep 1, 2020
Merged
@paulo-ferraz-oliveira
Copy link
Collaborator

Related to inaka/elvis_core@54c090e.

@elbrujohalcon
Copy link
Member Author

Fixed by inaka/elvis_core#124

@paulo-ferraz-oliveira
Copy link
Collaborator

Fixed by inaka/elvis_core#124

Nice. Shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elbrujohalcon @paulo-ferraz-oliveira