Turn macro names into a naming conventions rule

[elbrujohalcon]

Macro Names is a very strict rule that doesn't follow the regex standard of other similar rules (like Module Naming Convention). It would be a good idea to standardize it.

Ref: WhatsApp/erlfmt#91

[paulo-ferraz-oliveira]

Related to #404?

[elbrujohalcon]

You're right, this is a duplicate. But since this one has a ref, I'm gonna close @harenson's one :)

[paulo-ferraz-oliveira]

What should be the default for regex? I mean... -define('A-Z', 2) compiles just fine, but do we want to allow this, by default? I'm thinking of a simple [_A-Z0-9]+ but will search elsewhere if there are any conventions that could be followed.

We could also leave the default validation as is, "all uppercase", and only use regex if defined.

What's your idea, @elbrujohalcon?

[paulo-ferraz-oliveira]

I found that -define('A,aZ', 2). doesn't fail the tests either (or reports as bad analysis) since the regex used to find the macro name is too permissive. I haven't found the write one yet, but wanted to report on this so I don't forget it later.

[paulo-ferraz-oliveira]

Linked to inaka/elvis_core#131.

[paulo-ferraz-oliveira]

Reminder for future me: if this gets approved, you, @paulo-ferraz-oliveira, should update the Wiki.

[elbrujohalcon]

I wrote a few comments in that PR

[elbrujohalcon]

BTW… You can use [Fix inaka/elvis#...] in your PR titles/descriptions to automatically link them to the issues here.

[paulo-ferraz-oliveira]

BTW… You can use [Fix inaka/elvis#...] in your PR titles/descriptions to automatically link them to the issues here.

Done. But the link didn't "happen" though.

[jfacorro]

Done. But the link didn't "happen" though.

Sadly the link is only parsed in the comment section, the title is shown as plain text.

[paulo-ferraz-oliveira]

Done. But the link didn't "happen" though.

Sadly the link is only parsed in the comment section, the title is shown as plain text.

I actually kind of prefer it like this, since otherwise the titles would pollute the CHANGELOG.