Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential rule duplication #522

Closed
paulo-ferraz-oliveira opened this issue Sep 7, 2020 · 6 comments
Closed

Potential rule duplication #522

paulo-ferraz-oliveira opened this issue Sep 7, 2020 · 6 comments

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

Do you think having a rule no_behaviour_info (with a u) would make sense? It would simply be an alias for no_behavior_info. [I don't want to get into an argument over the English language, since I don't have a preference...]

I remember being surprised, a few years back, when I discovered that both spellings worked the same for erlang. I think, at a given moment in time, about 10 years ago, dialyzer would complain about missing stuff if the spelling was behavior.

@elbrujohalcon
Copy link
Member

I don't think we need a new rule. If no_behavior_info doesn't warn you about behaviour_info/1, it should.

@jfacorro
Copy link
Contributor

jfacorro commented Sep 8, 2020

I think that should be the case as well, that is, if it doesn't do it at the moment it should. 😄

@jfacorro
Copy link
Contributor

jfacorro commented Sep 8, 2020

I just checked and the style rule does check for both 🥳 , see here.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I just checked and the style rule does check for both 🥳 , see here.

I wasn't talking about the check itself, but the rule name. :) It was simply a new alias...

@jfacorro
Copy link
Contributor

jfacorro commented Sep 8, 2020

Aaah, I misunderstood then. I think it's probably better to have a single one to avoid confusion. I just updated the documentation so it mentions both spellings.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Aaah, I misunderstood then. I think it's probably better to have a single one to avoid confusion. I just updated the documentation so it mentions both spellings.

Got it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants