Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: Define ChildSpecs in either supervisor or worker #531

Closed
paulo-ferraz-oliveira opened this issue Sep 15, 2020 · 1 comment
Closed
Labels

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

For consistency, inside a given project, we should either define childspecs inside workers, or inside supervisors. That doesn't mean there aren't exceptions to the rule, but that's why rules are configurable :)

This should support option ignore.

Of course, a supervisor might supervise other supervisors, so we need to take care of that case. In any case, the goal should be to "have the childspec defined in the module that uses it" v. "have the childspec defined outside the module that uses it".

I'm not sure about the default in (see below): supervisor v. worker.

I propose [{elvis_style, childspecs, #{ in => supervisor, ignore => [] }.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I think the analysis, here, will easily become too complicated too soon. Closing it for reference, but abandoning the idea for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant