Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss whether seemingly text-oriented rules should move to a new API #542

Closed
paulo-ferraz-oliveira opened this issue Oct 6, 2020 · 2 comments
Closed

Discuss whether seemingly text-oriented rules should move to a new API #542

paulo-ferraz-oliveira opened this issue Oct 6, 2020 · 2 comments
Labels
elvis_core

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

The following functions aren't exactly "beam-oriented" in analysis, which leads me to think they're be better off in (upcoming) elvis_text_style:

  • operator_spaces
  • max_module_length
  • max_function_length

(though they seem to be parseable by AST - thus subject to ignore with MFA).

What say you?
@elbrujohalcon
Copy link
Member

inaka/elvis_core#138 (comment)

i.e. YES! All of them go to elvis_text_style.

Merged
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This will be handled in the linked pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
elvis_core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elbrujohalcon @paulo-ferraz-oliveira