Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import starling dictionary: The 'Create field' modal window does not close on 'Save' click #929

Open
vmonakhov opened this issue Jan 20, 2023 · 2 comments
Assignees
Labels
bug something doesn't work as expected. Has sub-labels: regression, backend, frontend, critical frontend bug is related to frontend

Comments

@vmonakhov
Copy link

/import_csv > Columns Mapping > Field Type

  • Click 'Create a new field' in drop-down menu
  • Print new field name, choose its type, click 'Save'
    !The 'Create field' modal window does not close on 'Save' click. The field is added on every 'Save' click

2023-01-20_13-03-30

@vmonakhov vmonakhov added bug something doesn't work as expected. Has sub-labels: regression, backend, frontend, critical frontend bug is related to frontend labels Jan 20, 2023
@myrix
Copy link
Contributor

myrix commented Jan 20, 2023

The problem is that on successful save the dialog tries to call a callback from the field selection, and fails with error because field selection is closed. It's related to 3) in #927, as the Create field dialog should be on top and should not require closing of field choice dialog to operate.

So, try and on exception refetch the fields query?

@vmonakhov
Copy link
Author

vmonakhov commented Jan 25, 2023

It's strange that the Field choice dialog closes on any click within the Create field dialog. May be just try/except is not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something doesn't work as expected. Has sub-labels: regression, backend, frontend, critical frontend bug is related to frontend
Projects
None yet
Development

No branches or pull requests

2 participants