New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alpha clamping #3

Open

RobinCamarasa opened this issue May 25, 2020 · 0 comments

RobinCamarasa commented May 25, 2020

Good afternoon,
I have been working on your implementation of Variational Dropout and something seems weird to me in the forward pass

            # Clip alpha
            self.log_alpha.data = torch.clamp(self.log_alpha.data, max=self.max_alpha)
            alpha = self.log_alpha.exp()

The code above seems to clamp the log of alpha and not the alpha itself which is not what we expect. Do I misinterpret you code or the theory here ?

RobinCamarasa closed this as completed

RobinCamarasa reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment