Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding organizer. #45

Open
holden opened this issue Oct 5, 2023 · 9 comments
Open

Adding organizer. #45

holden opened this issue Oct 5, 2023 · 9 comments

Comments

@holden
Copy link

holden commented Oct 5, 2023

What about allowing the addition of organizer and/or other optional fields that ICS allows and most of them use.

It currently doesn't allow any options not specified eg unknown keyword: :organizer

CleanShot 2023-10-05 at 12 17 26@2x

@jaredlt
Copy link
Owner

jaredlt commented Oct 7, 2023

@holden thanks for the feature request. It doesn't look like organizer is supported for the web calendars (Google, Outlook, Yahoo) but I could explore adding it to ICS.

Can you share the steps you took to get that screenshot to appear? It looks like the Google Calendar event component you get in an email but I can't seem to get it to appear at the moment. Did you download the generated ICS and then attach it to an email?

@holden
Copy link
Author

holden commented Oct 7, 2023

Yes, exactly. I downloaded the ICS file @cal.ical_url and sent it to myself as an email to test how it would appear. As I want to use this in a couple of different ways including sending out email reminders and well as clicking from a website.

Your solution seemed to be the only one focused on both!

I pulled organizer from what I saw on the icalendar page: https://github.com/icalendar/icalendar#example

Thanks,

@jaredlt
Copy link
Owner

jaredlt commented Oct 11, 2023

Gotcha, thank you for the detail. I may have some time on Friday to have a look at this. Will keep you updated.

As an aside, I have no idea why I didn't use the icalendar gem to generate the ICS files... I should really move over to it.

@holden
Copy link
Author

holden commented Oct 11, 2023

Yeah, actually when I first came across your gem I figured icalendar would be a dependency. ;-)

@jaredlt
Copy link
Owner

jaredlt commented Oct 13, 2023

@holden could you test the following 3 ICS files for me? (could you send them to yourself and verify what shows for the Gmail preview?)

ics-tests.zip

For Organizer, it looks like you can provider an email and a name. According to https://icalendar.org/validator.html all 3 are valid ICS files (and they produce the same formatting as the icalendar gem examples) but when I send them to Gmail only the one with both name and email displays the event preview component (the other two don't show the preview at all for me).

If it's the same for you then I'll just require that if you're adding an Organizer then you must add both Name and Email, but I wanted to check if you get the same results first.

@holden
Copy link
Author

holden commented Oct 13, 2023

Weirdly email or name alone doesn't do anything in Gmail.

But Name and Email together work.
CleanShot 2023-10-13 at 16 58 18

@jaredlt
Copy link
Owner

jaredlt commented Oct 27, 2023

Sorry for the delay here! I have this working locally and will push it up for a new release shortly.

@holden
Copy link
Author

holden commented Oct 28, 2023

No problem. That would be great! Thanks

@jaredlt
Copy link
Owner

jaredlt commented Oct 30, 2023

@holden I've just released v0.4.0 - can you test it out and let me know if any issues?

You provide the organizer attribute like so:

    organizer: { 
      name: "First Last",
      email: "email@example.com"
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants