Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon for dark menubar #9

Open
Grawl opened this issue Nov 1, 2017 · 3 comments
Open

Icon for dark menubar #9

Grawl opened this issue Nov 1, 2017 · 3 comments

Comments

@Grawl
Copy link

Grawl commented Nov 1, 2017

I can't see app is launched before I turned off "Use dark menu bar and Dock" option into system general settings.

Please, provide an inverted (white) menubar icon version.

@johansatge
Copy link
Owner

johansatge commented Nov 4, 2017

Hi,

thanks for the report.

The code should handle this case by using the icon and alticon properties of the Tray, but it does not seem to work (anymore? I'm testing on macOS 10.12.5)

pawnee/app/assets/js/app.js

Lines 113 to 114 in 116f219

icon: 'assets/css/images/menu_icon.png',
alticon: 'assets/css/images/menu_alticon.png',

If someone wants to have a look, please feel free to do so - maybe updating nwjs to a more recent version would fix the issue?

@Grawl
Copy link
Author

Grawl commented Nov 9, 2017

I just figured out that inverted icon is applied but not rendered at all on dark menubar. Until I clicked on place where it should be.

@Grawl
Copy link
Author

Grawl commented Nov 9, 2017

pawnee dark menubar icon bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants