Skip to content

Commit

Permalink
feat(runner): Use favicon in static runner pages
Browse files Browse the repository at this point in the history
I noticed a "TOOD" [sic] in the runner page source that was added by
e9fa51a. I figured I'd take a swing at doing it. This commit
brings down the favicon from

  http://karma-runner.github.io/assets/img/favicon/favicon.ico

and wires up the static pages to use it. I considered inlining it as a
data-uri, but the image was big enough to make the source pretty gross
so I settled on using an external file.

Along the way, I found and fixed a couple of minor spelling and
whitespace errors.
  • Loading branch information
lencioni committed May 20, 2015
1 parent 1b69db1 commit 6cded4f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 7 deletions.
4 changes: 1 addition & 3 deletions static/client.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
<head>
%X_UA_COMPATIBLE%
<title>Karma</title>
<!-- TOOD(vojta): create simple favicon and cache it -->
<link href="data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T///////8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=" rel="icon" type="image/x-icon">
<link href="favicon.ico" rel="icon" type="image/x-icon">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style type="text/css">
iframe {
Expand All @@ -31,7 +30,6 @@

.online {
background: #6C4;

}

.idle {
Expand Down
2 changes: 1 addition & 1 deletion static/context.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!--
This is the execution context.
Loaded within the iframe.
Realoaded before every execution run.
Reloaded before every execution run.
-->
<html>
<head>
Expand Down
5 changes: 2 additions & 3 deletions static/debug.html
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
<!doctype html>
<!--
This file is almost the same as context.html - loads all source files,
but it's purpose is to be loaded in the main frame (not within an iframe),
but its purpose is to be loaded in the main frame (not within an iframe),
just for immediate execution, without reporting to Karma server.
-->
<html>
<head>
%X_UA_COMPATIBLE%
<title>Karma DEBUG RUNNER</title>
<!-- TOOD(vojta): create simple favicon and cache it -->
<link href="data:image/x-icon;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQEAYAAABPYyMiAAAABmJLR0T///////8JWPfcAAAACXBIWXMAAABIAAAASABGyWs+AAAAF0lEQVRIx2NgGAWjYBSMglEwCkbBSAcACBAAAeaR9cIAAAAASUVORK5CYII=" rel="icon" type="image/x-icon" />
<link href="favicon.ico" rel="icon" type="image/x-icon" />
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
</head>
<body>
Expand Down
Binary file added static/favicon.ico
Binary file not shown.

0 comments on commit 6cded4f

Please sign in to comment.