-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Simple auto-complete suggestions on kiwix dot org search bar #911
Comments
Should I work on this? |
For the moment, not convinced of the value of the feature. Maybe an explanation about the problem would help? |
I understand that the value this feature brings is not a lot. How it helps is: I could type type "reve" to quickly see if a book on reverse engineering exists, instead of searching for it. It's a simple feature I wanted to try contributing towards as my introduction to open source, before trying more complex contributions. About the problem, I will try setting up the project again in a few hours and will let know if I'm still facing problems. |
Have you tried https://github.com/kiwix/kiwix-build ? |
@kelson42 I think that the feature will be valuable (e.g. will help to avoid missed search results due to typos). However it shouldn't be implemented as proposed in the ticket description. Instead the |
@veloman-yunkan I understand now and agree. Would be probably great to rephrase this ticket in a new one. |
@veloman-yunkan would you explain to me a little bit more about the |
Currently, the search bar doesn't show auto-complete suggestions for the books displayed on the page.
I believe it would be a simple addition as it would help discoverability of different books offered amongst the 4000+ options.
My Approach
Initially, I was planning to implement a common trie-based javascript autocomplete solution as I have done in previous personal js projects. I will scrape all the book titles that come after
<div id="book__title">
and before</div>
,then I'll add all the book results to a JSON file. Then I will get the autocomplete function to work on this.Lemme know if my approach has any flaws or if could be better.
Problems
I am new to open source and working with large codebases is scary. So I hope I could get assistance with a few problems.
The text was updated successfully, but these errors were encountered: