Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is manually maintained? #187

Open
fabiand opened this issue Jun 29, 2024 · 3 comments
Open

README.md is manually maintained? #187

fabiand opened this issue Jun 29, 2024 · 3 comments
Labels

Comments

@fabiand
Copy link
Member

fabiand commented Jun 29, 2024

What happened:
Could it be that the READ is manually maintainted instead of auto generated?

What you expected to happen:
To have README.md to be auto generated

How to reproduce it (as minimally and precisely as possible):
Always

Additional context:
https://github.com/fabiand/instanceTypes/blob/main/hacks/docs.py is auto generating a readme based on the metadata/yamls.

Environment:

  • KubeVirt version (use virtctl version): N/A
  • Kubernetes version (use kubectl version): N/A
  • VM or VMI specifications: N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Others: N/A
@fabiand
Copy link
Member Author

fabiand commented Jun 29, 2024

[fabiand@toolbox common-instancetypes (main)]$ git grep "Has GPUs"
README.md:*Has GPUs*                  |     |     |      |  ✓   |     |
README.md:- *Has GPUs* - Has GPUs predefined.
[fabiand@toolbox common-instancetypes (main)]$

@0xFelix
Copy link
Member

0xFelix commented Jul 1, 2024

The README is partially auto generated, partially manually maintained.

See https://github.com/kubevirt/common-instancetypes/blob/main/scripts/readme.sh

Does this meet your requirements?

@fabiand
Copy link
Member Author

fabiand commented Jul 1, 2024

@0xFelix did you know about https://github.com/fabiand/instanceTypes/blob/main/hacks/docs.py (rendered: https://github.com/fabiand/instanceTypes/blob/main/README.md) ?

It's carefulyl written (tho not beautiful), because it addresses the following:

  1. It's for the suer
  2. therefore it has a diagram to give a high level overview over the ITs and their "classification"
  3. It has a series comparison to show the user how the series technically differ
  4. It provides a human friendly more elaborative description for each series
  5. It lists the available sizes for each series
  6. It's for the developer
  7. As all of this is quto generated
  8. It firces the developer to keep all the information in the metadata of the objects, aka makes it available to higher level consumers like a UI

Does this meet your requirements?

because of the above i'd say carefully no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants