Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error setting announce list #65

Closed
luckiestone opened this issue Nov 16, 2023 · 10 comments
Closed

Error setting announce list #65

luckiestone opened this issue Nov 16, 2023 · 10 comments
Assignees
Labels
bug Something isn't working transmission-bug For stuff caused by (supposed and/or confirmed) bugs in the daemon
Milestone

Comments

@luckiestone
Copy link

If multiple items are selected and announce tracker in properties is changed, there would be an error Error setting announce list
Do know if this is a issue caused by TR4, as mentioned in transmission-remote-gui#1428 (comment)

@lighterowl
Copy link
Owner

This shouldn't be caused by what I described in that other comment as all the RPC endpoints that transgui uses are still functional, though deprecated.

Can you describe what you're trying to do in more detail (from what I understand, changing the announce address for multiple selected torrents at the same time), and the version of the daemon that you're running?

@luckiestone
Copy link
Author

This shouldn't be caused by what I described in that other comment as all the RPC endpoints that transgui uses are still functional, though deprecated.

Can you describe what you're trying to do in more detail (from what I understand, changing the announce address for multiple selected torrents at the same time), and the version of the daemon that you're running?

Yes, that's what I did. I was previously using transgui https://github.com/transmission-remote-gui/transgui/releases/tag/v5.18.0 with same issue. The daemon version is 4.0.3, I'll try to update it to latest.

@lighterowl lighterowl self-assigned this Nov 18, 2023
@lighterowl
Copy link
Owner

If this happened with 5.18.0, then it's either a bug in transgui which incorrectly generates the RPC requests (more likely IMHO) or a bug introduced in the daemon between v4 and older versions (less likely but not impossible). I'll test with different versions so we know what's going on.

@lighterowl lighterowl added the bug Something isn't working label Nov 18, 2023
@luckiestone
Copy link
Author

luckiestone commented Nov 18, 2023

thank you, updated to 4.0.4 but no luck. I'm sure that no such bug with 5.18.0 with v2, but not sure if it's introducted in the first release of v4.

@lighterowl
Copy link
Owner

lighterowl commented Nov 18, 2023

Looks like this is a Transmission bug after all, I tested both transgui 5.18.0 and 5.18.4f with daemons 2.94 and 4.10-dev. Connecting to 2.94 from both transgui versions results in the tracker list being updated successfully.

I'll file an issue in the Transmission project once I collect more information.

@lighterowl lighterowl added transmission-bug For stuff caused by (supposed and/or confirmed) bugs in the daemon and removed bug Something isn't working labels Nov 18, 2023
@lighterowl
Copy link
Owner

lighterowl commented Nov 19, 2023

Bringing back the bug label as transgui's behaviour isn't 100% correct here either, as it assumes that tracker IDs are indices to an array of consecutively stored tracker addresses. This is not true anymore with 4.0 and has never been specified explicitly so transgui (knowingly or not) relies on undocumented behaviour.

I do hope that the Transmission issue ends up bringing back the old ID semantics as they allow to perform trackerRemove more efficiently - however, behaviour with current 4.0 versions still must be fixed so a fix in transgui is needed either way.

On top of all that, transgui should use torrent-set::trackerList when RPC version is >= 17.

@lighterowl lighterowl added the bug Something isn't working label Nov 19, 2023
@lighterowl
Copy link
Owner

@luckiestone The newest builds will use trackerList when talking to Transmission 4.0 or newer, and my testing has shown that this error is no longer returned and trackers are set properly for multiple torrents.

Please try out the development builds (Linux, Windows, macOS) and let me know if this is fixed for you too.

@luckiestone
Copy link
Author

@luckiestone The newest builds will use trackerList when talking to Transmission 4.0 or newer, and my testing has shown that this error is no longer returned and trackers are set properly for multiple torrents.

Please try out the development builds (Linux, Windows, macOS) and let me know if this is fixed for you too.

Thank you! I've done some tests, and it's fixed for tr4. However, when I connect to tr2.94. Setting announce list even for one single torrent shows Privileged instruction, and the GUI crashed.

@lighterowl
Copy link
Owner

lighterowl commented Dec 4, 2023

@luckiestone Thanks for testing. This was caused by a very embarrassing mistake on my part. Please try out the newer builds : macOS, Linux, Windows

@lighterowl lighterowl added this to the 5.18.4 milestone Dec 4, 2023
@lighterowl
Copy link
Owner

Closing as fixed in latest release. Please create a new issue if you still experience problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working transmission-bug For stuff caused by (supposed and/or confirmed) bugs in the daemon
Projects
None yet
Development

No branches or pull requests

2 participants