Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derived context doesn't call parent context hooks #5774

Open
yzfeng2020 opened this issue Jun 19, 2024 · 0 comments
Open

Derived context doesn't call parent context hooks #5774

yzfeng2020 opened this issue Jun 19, 2024 · 0 comments

Comments

@yzfeng2020
Copy link
Contributor

The current implementation for creating a new derived context doesn't seem to keep track of the hooks of parent context, so that the parent context hooks won't be called when ctx.push is called on the derived context.

public static ClientRequestContext newDerivedContext(ClientRequestContext ctx,

As suggested by @trustin, we could fix this by making sure a derived context keeps the reference to the parent context's hook list as well as its own hook list, so that both of them are invoked when the derived context needs to call hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant