Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace warnings about potential endless loops by timeouts and error messages #4

Open
maehw opened this issue Sep 19, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@maehw
Copy link
Owner

maehw commented Sep 19, 2022

The generator may spit out several warning messages like the following:

[ WARNING] Entering potential endless loop (trying to merge AND gates)

This has been added as the generator is known to hang for some designs. The root cause is currently unknown - as it simply has not been analyzed yet.

Design to reproduce: https://github.com/maehw/wokwi-lookup-table-generator/blob/main/demos/4bit-popcount.logic.json

This may be helpful, but is also annoying as the warning messages will appear for every design.

A better way to detect endless loops would be to use timeouts (wait for some time and abort when the loop has not finished yet). Those timeouts may be dynamic as they should grow with the design complexity (or input/output size). But we could also use a static timeout as the machines to run the generator on should not be too low.

@maehw maehw added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant