Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs display the close tab shortcut as Ctrl+F4, even though that's not bound by default. They should display what the actual keybinding is instead. #10109

Open
uvicorn opened this issue May 17, 2021 · 3 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@uvicorn
Copy link

uvicorn commented May 17, 2021

maintainer note: blocked on upstream microsoft/microsoft-ui-xaml#4930


Windows Terminal version (or Windows build number)

windows terminal version: 1.7.1033.0

Other Software

No response

Steps to reproduce

  1. open terminal
  2. hover the mouse over the cross

there is no reference to the ctrl + f4 key in settings.json

Expected Behavior

ctrl+shift+w everywhere

Actual Behavior

изображение

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 17, 2021
@zadjii-msft
Copy link
Member

Huh. We get that text from WinUI on the tab close button by default. I bet we could override that somehow.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels May 17, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone May 17, 2021
@zadjii-msft zadjii-msft added the Issue-Bug It either shouldn't be doing this or needs an investigation. label May 17, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2021
@kovdu
Copy link
Contributor

kovdu commented May 18, 2021

Seems to be initialized here https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/TabView/TabView.cpp#L45 as a private member of the TabView class with the text taken from https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/TabView/Strings/en-us/Resources.resw#L137.

So I guess WinUI would first need to be adapted to make the tooltip on the close button configurable?

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 7, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@vadimkantorov
Copy link

Also stumbled on this. F-keys require some finger acrobatics on my laptop. It would be nice to have Ctrl+W/Ctrl+Shift+W supported and hinted correctly!

@zadjii-msft zadjii-msft changed the title incorrect display of the name of the tab close key Tabs display the close tab shortcut as Ctrl+F4, even though that's not bound by default. They should display what the actual keybinding is instead. Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

4 participants