Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record failed TLS client handshakes in UI and to mitm dump file (not only in log) #6861

Open
jpstotz opened this issue May 21, 2024 · 1 comment
Labels
kind/feature New features / enhancements

Comments

@jpstotz
Copy link
Contributor

jpstotz commented May 21, 2024

Problem Description

More and more mobile apps use certificate pinning on connections which let the connection fail in the TLS handshake phase on client side. Those connection attempts are currently only logged, however in my opinion it should be recorded similar to successful connections so that they were included when the recorded traffic is saved to a file, as the app tried to establish a connection with a server it most likely just failed because of mitmproxy.

Proposal

TLS client handshake failed errors should be recorded as flow so that they can be saved to the mitmproxy dump file.

@jpstotz jpstotz added the kind/feature New features / enhancements label May 21, 2024
@mhils
Copy link
Member

mhils commented May 23, 2024

refs #6421 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features / enhancements
Projects
None yet
Development

No branches or pull requests

2 participants