Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blockech addon #6876

Merged
merged 9 commits into from
May 28, 2024
Merged

Add blockech addon #6876

merged 9 commits into from
May 28, 2024

Conversation

errorxyz
Copy link
Contributor

@errorxyz errorxyz commented May 26, 2024

Description

This PR adds a blockech addon that prevents encrypted SNI by removing HTTPS records from answers in an effort to prevent the ech key from being exchanged. The next step to this PR would be to parse HTTPS records and remove the ech key alone from those records.

Checklist

  • I have updated tests where applicable.
  • I have added an entry to the CHANGELOG.

@errorxyz errorxyz marked this pull request as ready for review May 26, 2024 11:39
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first step, some comments below! 😃

mitmproxy/addons/__init__.py Outdated Show resolved Hide resolved
mitmproxy/addons/blockech.py Outdated Show resolved Hide resolved
mitmproxy/addons/blockech.py Outdated Show resolved Hide resolved
mitmproxy/addons/blockech.py Outdated Show resolved Hide resolved
Copy link
Member

@mhils mhils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mhils mhils enabled auto-merge (squash) May 28, 2024 15:15
@mhils mhils disabled auto-merge May 28, 2024 16:10
@mhils mhils merged commit de871df into mitmproxy:main May 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants