Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/pin/ls endpoint is falsely typed #53

Open
MagnificentPako opened this issue May 26, 2019 · 1 comment
Open

/pin/ls endpoint is falsely typed #53

MagnificentPako opened this issue May 26, 2019 · 1 comment

Comments

@MagnificentPako
Copy link
Contributor

ApiV0PinLs has arg as required argument, while https://docs.ipfs.io/reference/api/http/#api-v0-pin-ls states that it is optional. By enforcing the arg parameter one is unable to list all pinned objects of a node. Would it be possible to rectify this? Is editing the file and sending a PR an option or would those changes be lost because you run the auto-gen?

@kim
Copy link
Collaborator

kim commented May 27, 2019

Good catch!

Please do send a PR. As it turned out, there is only limited value in generating code for the IPFS API - they don't maintain a swagger (or similar) spec, and it is virtually impossible to guess the return types of all the endpoints. So, going forward, we'll have to maintain this library by hand (for which we don't have much resources at the moment, though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants