Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Filter search results to a single SDN type #525

Open
tomdaffurn opened this issue Dec 15, 2023 · 1 comment
Open

search: Filter search results to a single SDN type #525

tomdaffurn opened this issue Dec 15, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@tomdaffurn
Copy link
Contributor

Watchman Version: v0.27.0

What were you trying to do?
Filter results to entities of type "individual".

This is complicated by the fact that AltNames and Addresses are not stored in memory with the sdnType of their SDN. Also difficult because different lists have different enums for type. e.g. ukConsolidatedSanctionsList has "GroupType": "Individual", euConsolidatedSanctionsList has "EntitySubjectType": "person".

I suggest defining a generalised type enum in the Watchman API, then mapping that into the types of each watchlist. Similar to what is done for name.

What did you expect to see?
Results in SDNs, altNames, addresses, euConsolidatedSanctionsList, ukConsolidatedSanctionsList (maybe more lists) should be only for individuals.

What did you see?
Results are present in all lists (except SDNs) for Companies, Vessels, etc.

How can we reproduce the problem?
Use a Query or Name search with sdnType=individual. e.g https://oss.moov.io/watchman/search?q=a&sdnType=individual or https://oss.moov.io/watchman/search?name=a&sdnType=individual

@adamdecaf adamdecaf added bug Something isn't working enhancement New feature or request labels Dec 20, 2023
@adamdecaf
Copy link
Member

Yea I agree. I think creating a generalized model for entity lists would help solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants