Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize polling data flow #78

Open
3 of 4 tasks
norbertsuski opened this issue Jul 16, 2020 · 1 comment
Open
3 of 4 tasks

Optimize polling data flow #78

norbertsuski opened this issue Jul 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@norbertsuski
Copy link
Contributor

norbertsuski commented Jul 16, 2020

Summary

Current implementation has following issues with polling optimization which can be improved:

  • one tile is fetching all data twice - once for summary and once for recent incidents, sometimes it is the same source of information that could be fetched once
  • tile itself can fetch all data and than pass last incidents to small timeline on tile, instead of creating two Network objects to fetch data
  • when opening big timeline, new polling process starts, which is getting the same data as tile
  • when removing tile, data is still polled in background

Possible Solution

  • fetch data once and format as summary and recent incidents in main StatusPage component (if possible)
  • remove unnecessary Network object initialization in CurrentIncidents and pass incidents from StatusPage
  • add possibility to handle onClose event when StackedNerdlet is closed which will allow to stop polling data
  • clear polling when user deletes tile
@norbertsuski norbertsuski added the enhancement New feature or request label Jul 16, 2020
@norbertsuski
Copy link
Contributor Author

I covered points 1, 2 and 4, only 3 is not possible at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant