Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contentId can't be replaced and is more of a streamId #66

Open
timalacey opened this issue May 10, 2024 · 1 comment · May be fixed by #73
Open

contentId can't be replaced and is more of a streamId #66

timalacey opened this issue May 10, 2024 · 1 comment · May be fixed by #73
Assignees

Comments

@timalacey
Copy link
Collaborator

Issue 1
nrAddVideoAttributes() overrides nrCustomAttributes, meaning contentId cannot be overwritten with nrSetCustomAttribute(m.nr, "contentId", "abcd"))

ev = nrAddVideoAttributes(ev)

Issue 2
The default value for contentId relies on the streamUrl, making it a streamId.

ev.AddReplace("contentId", ba.GetCRC32())

Context: we have multiple streams per asset. So we want contentId to refer to the assetId of the content, similar to contentTitle.

@asllop asllop self-assigned this May 10, 2024
@asllop asllop linked a pull request Jul 12, 2024 that will close this issue
@asllop asllop linked a pull request Jul 12, 2024 that will close this issue
@asllop
Copy link
Contributor

asllop commented Jul 12, 2024

Hi @timalacey , issue 1 is already fixed and will be released soon. Regarding issue 2, contentId was designed as a way to facet by stream URL, but using an integer instead of a string, which is more convenient in terms of NRQL performance. But I would like to know more about your specific use case. Is there any property from the video object/metadata that could cover your needs better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants