Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video aspect ratio wrong in public view #1831

Open
philippjeschek opened this issue Jul 26, 2023 · 8 comments · May be fixed by #2349
Open

Video aspect ratio wrong in public view #1831

philippjeschek opened this issue Jul 26, 2023 · 8 comments · May be fixed by #2349
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@philippjeschek
Copy link

Steps to reproduce

  1. Upload video with 9:16 aspect ratio
  2. Share video, hide download and copy public link
  3. Open shared link in new tab

Expected behavior

Video should be displayed in correct aspect ratio.

Actual behavior

Video gets displayed very large/zoomed in and you have to scroll to view the full video

Host OS

Ubuntu 22.04.2 LTS

Nextcloud AIO version

27.0.1

Current channel

Stable

Other valuable info

Only happend after upgrading from 27.0.0 to 27.0.1. In 27.0.0 everything works as expected.

Example file: https://cloud.philippjeschek.com/s/XgYj95qRCntm59d

@philippjeschek philippjeschek added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Jul 26, 2023
@szaimen szaimen transferred this issue from nextcloud/all-in-one Jul 26, 2023
@nicrame
Copy link

nicrame commented Jul 28, 2023

I confirm this. Same situation even with videos with landscape ratio video files shared by public link. Control buttons and part of the videos are not visible without scrolling down. Nextcloud 27.0.1, checked with Chrome and Firefox 115.

@creopard
Copy link

creopard commented Jan 25, 2024

Also confirmed.
Still happening in Nextcloud 28.0.1, also with videos in landscape ratio and shared by public link.

@Lawkss
Copy link

Lawkss commented May 6, 2024

Same here on 28...

@Lawkss
Copy link

Lawkss commented Jul 3, 2024

Also on NC 29.

@sptcguy
Copy link

sptcguy commented Jul 6, 2024

In 27.1.11:

If I do:

.view__file {
  margin: 0 auto; 
}

#imgViewer .view__file {
  height: 100%;
  width 45vh;
}

It seems to remedy the issue. Obviously I need to do some more testing but if it looks ok and the NC devs haven't already fixed it I'll create a pull request.

@sptcguy sptcguy linked a pull request Jul 8, 2024 that will close this issue
@sptcguy
Copy link

sptcguy commented Jul 8, 2024

I think I tracked it down to the Videos.vue file. It has the max-height attribute set to 100%. If I remove that, the video displays correctly across desktop and mobile.

@artonge
Copy link
Contributor

artonge commented Jul 8, 2024

Could someone open a PR with a fix? :)

@sptcguy
Copy link

sptcguy commented Jul 8, 2024

Could someone open a PR with a fix? :)

Done:
#2349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants