Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests Failing ... 😞 #1

Open
nelsonic opened this issue Dec 7, 2018 · 3 comments
Open

Tests Failing ... 😞 #1

nelsonic opened this issue Dec 7, 2018 · 3 comments

Comments

@nelsonic
Copy link

nelsonic commented Dec 7, 2018

Greetings @nocursor! β˜€οΈ

We are delighted that you have crafted and released this package! (thank you!) πŸŽ‰
(we were in the process of writing our own https://github.com/dwyl/cid when we discovered yours!)

I tried to run the tests on my localhost but they failed with the latest Elixir 1.7
image

so I forked your repo to: https://github.com/nelsonic/ex-cid
and added a .travis.yml file to run the tests on TravisCI and again they failed:
https://travis-ci.org/nelsonic/ex-cid/builds/464903813#L595
image

We are keen to use your work (and support your efforts to maintain it!)
Please inform what steps are required to make the tests pass so we can proceed.
Thanks! ✨

@nelsonic nelsonic mentioned this issue Dec 7, 2018
@nelsonic
Copy link
Author

I cloned this repository onto my localhost and attempted to run

iex -S mix

to run the examples from the README.md
but got the same error as above:
image

Error while loading project :multibase at /code/ex-cid/deps/multibase
** (Mix) Trying to load Multibase.MixProject from "/code/ex-cid/deps/multibase/mix.exs" 
but another project with the same name was already defined at "/code/ex-cid/mix.exs"

Has anyone else managed to get the code in this repo working?

@SimonLab
Copy link

SimonLab commented Jan 15, 2019

I think this is due to a naming error of the module in the mix.exs file.
Instead of using defmodule Multibase.MixProject do which is defined for the following package https://github.com/nocursor/ex-multibase the name module might need to be something like defmodule Cid.MixProject do

see

defmodule Multibase.MixProject do

@nelsonic
Copy link
Author

@SimonLab if/when you have time, please create a PR for this fix.
(if you don't have time right now, I can create it ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants