Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests: Add CloseMainWindow #1138

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BenJuan26
Copy link

@BenJuan26 BenJuan26 commented May 12, 2023

depends on obsproject/obs-studio#8889

Description

Adds a new request called CloseMainWindow which closes the main window and cleanly shuts down OBS.

Motivation and Context

This request allows external applications to cleanly shut down OBS.

It implements #511

How Has This Been Tested?

Tested OS(s): Windows 10
Testing method: Postman

After connecting and handshaking, I sent this payload:

{
    "op": 6,
    "d": {
        "requestType": "CloseMainWindow",
        "requestId": "19b2e634-67b8-470a-a216-fc0f6a87160e"
    }
}

OBS (with the changes in the obs-studio PR linked at the top) responded by cleaning up its resources and shutting down. The events of the shutdown can be seen through the websocket:

image

Types of changes

  • New request/event (non-breaking)

Checklist:

  • I have read the Contributing Guidelines.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • My code is not on master or a release/* branch.
  • The code has been tested.
  • I have included updates to all appropriate documentation.

Adds a new request called CloseMainWindow which closes the main window
and cleanly shuts down OBS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant