Targeting sub-schema doesn't work alone

[toddbaert]

The targeting sub-schema doesn't work if used by itself. It's entirely correct and works well if used as part of the parent schema, but doesn't work in isolation.

This seems to be because we only DEFINE "targeting" in this schema, but don't use it to validate the top-level object.

We need to:

• use the existing definition to validate the top-level object
• add 1 positive and 1 negative test to make sure the schema works as expected
  • we already have lots of test coverage here where we iterate over all the JSON in the positive and negative dirs as part of the parent, we just need this new single positive/negative test to load the targeting schema in isolation and make sure it works alone as well. This means a new test which loads just the targeting schema instead of the definition schema, similar to this line:

    flagd-schemas/json/flagd_definitions_test.go

    Line 22 in 61523e5

    compiledSchema, err = schemaLoader.Compile(gojsonschema.NewStringLoader(flagd_definitions.FlagSchema))

[toddbaert]

cc @aepfli

[aepfli]

Thank you for creating the bug - below i added a small spoiler for the changes to the targeting.json ;)

behind this is a spoiler for the solution

At line 6 of the targeting.json we need to add an

 "type": "object",
 "anyOf": [
   {
     "$ref": "#/definitions/targeting"
   }
 ],

https://github.com/open-feature/flagd-schemas/blob/main/json/targeting.json#L6

disclaimer: maybe a allOf would be even enough