Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opamp extension should support http #31389

Closed
jaronoff97 opened this issue Feb 22, 2024 · 3 comments
Closed

Opamp extension should support http #31389

jaronoff97 opened this issue Feb 22, 2024 · 3 comments
Labels
enhancement New feature or request extension/opamp needs triage New item requiring triage

Comments

@jaronoff97
Copy link
Contributor

Component(s)

extension/opamp

Is your feature request related to a problem? Please describe.

Right now the opamp extension only supports ws, we should also support http which is supported in opamp-go

Describe the solution you'd like

Change the logic to check for an http(s) url and use the http client.

Describe alternatives you've considered

No response

Additional context

No response
@jaronoff97 jaronoff97 added enhancement New feature or request needs triage New item requiring triage labels Feb 22, 2024
@jaronoff97
Copy link
Contributor Author

i can take this on.

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jaronoff97
Copy link
Contributor Author

closing in favor of #31390

This was referenced Feb 27, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request extension/opamp needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaronoff97