Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and enhance tracing support for shipping service (Rust) #54

Closed
6 of 10 tasks
cartersocha opened this issue May 30, 2022 · 1 comment · Fixed by #260
Closed
6 of 10 tasks

Review and enhance tracing support for shipping service (Rust) #54

cartersocha opened this issue May 30, 2022 · 1 comment · Fixed by #260
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

cartersocha commented May 30, 2022 •
edited by julianocosta89
Loading

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)
  • Update the centralized tracing doc

Referencing: #42

Service: https://github.com/open-telemetry/opentelemetry-demo-webstore/blob/main/src/shippingservice/README.md

Rust dependent on this item: #35
@cartersocha cartersocha added enhancement New feature or request help wanted Extra attention is needed required-for-release labels May 30, 2022
@cartersocha cartersocha changed the title Review and enhance tracing support for shipping service (Go / Rust) Review and enhance tracing support for shipping service (Rust) Jun 17, 2022
@cartersocha cartersocha added good first issue Good for newcomers and removed required-for-release labels Jul 14, 2022
@cartersocha cartersocha mentioned this issue Jul 26, 2022
Closed
@puckpuck puckpuck mentioned this issue Aug 5, 2022
Merged
4 tasks
@julianocosta89 julianocosta89 mentioned this issue Aug 25, 2022
Merged
1 task
@cartersocha cartersocha reopened this Aug 25, 2022
@cartersocha
Copy link
Contributor Author

Tracing is code complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
No open projects
OpenTelemetry Community Demo - Completeness
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[shipping] - add span attributes honeycombio/opentelemetry-demo
1 participant
@cartersocha