Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue starting demo with Podman #993

Closed
dd4gg opened this issue Jul 20, 2023 · 5 comments · Fixed by #1507
Closed

Issue starting demo with Podman #993

dd4gg opened this issue Jul 20, 2023 · 5 comments · Fixed by #1507
Labels
bug Something isn't working

Comments

@dd4gg
Copy link

dd4gg commented Jul 20, 2023

When I execute podman-compose, I hit the same issue:

$ podman pull ghcr.io/open-telemetry/demo:1.4.0-traceBasedTests
Trying to pull ghcr.io/open-telemetry/demo:1.4.0-traceBasedTests...
Error: initializing source docker://ghcr.io/open-telemetry/demo:1.4.0-traceBasedTests: reading manifest 1.4.0-traceBasedTests in ghcr.io/open-telemetry/demo: manifest unknown

Is this a valid container that is supposed to be in the ghcr.io ?

@svrnm
Copy link
Member

svrnm commented Jul 21, 2023

@open-telemetry/demo-approvers please take a look.

@dd4gg you may consider raising this issue with the demo repository

@austinlparker austinlparker transferred this issue from open-telemetry/opentelemetry.io Jul 21, 2023
@austinlparker
Copy link
Member

Hi, I've transferred this issue to the demo repository.

@austinlparker austinlparker changed the title Docker deployment Issue starting demo with Podman Jul 21, 2023
@austinlparker austinlparker added the bug Something isn't working label Jul 21, 2023
@styblope
Copy link
Contributor

I could replicate the issue and found the cause with multiple things playing out:

  1. The image ghcr.io/open-telemetry/demo:1.4.0-traceBasedTests isn't indeed present in the repository because it isn't included in the GHA image build workflow.
  2. The traceBasedTests service is associated with a profile in docker-compose.yml. Docker-compose services with assigned profiles aren't started unless one explicitly enables them using ``--profile` option. Therefore, the service should not be started using the normal demo startup command.
  3. The reason podman-compose wants to pull the (nonexistent) image is because it doesn't yet implement profiles in the current v1.0.6 release; it will effectively start all containers declared in the compose file regardless the profile settings. The option is already merged in podman-compose upstream so hopefully due out soon.

If the various podman quirks get resolved, I think it would be worth opening up a discussion for qualifying podman as an inclusive build/run option next to docker.

@austinlparker
Copy link
Member

Is this still an issue in 1.8?

@puckpuck
Copy link
Contributor

It's been 11+ months since the PR to fix this in podman compose was merged, and still no release from their platform. Do we have any insight on if/when they will do a release?

The other way is to workaround the issue in podman compose and publish a traceBasedTests image as well as everything else we do. We already publish a frontendTests one, so I don't see why we can't add this one too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants