Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect service.name and service.version based on Implementation-Title and Implementation-Version #10615

Closed
zeitlinger opened this issue Feb 21, 2024 · 2 comments · Fixed by #10621
Assignees
Labels
enhancement New feature or request

Comments

@zeitlinger
Copy link
Member

zeitlinger commented Feb 21, 2024

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Docs

Gradle

jar {
    manifest {
        attributes("Implementation-Title": project.name, "Implementation-Version": version)
    }
}
@zeitlinger zeitlinger added the enhancement New feature or request label Feb 21, 2024
@zeitlinger zeitlinger self-assigned this Feb 21, 2024
@jeanbisutti
Copy link
Member

produces better results than jar file detector

Could you please elaborate

@zeitlinger
Copy link
Member Author

produces better results than jar file detector

Could you please elaborate

Jar files sometimes get renamed in docker build files (e.g. to app.jar) - while metadata gets preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants