Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow failed: GraalVM native tests (#254) #10634

Closed
github-actions bot opened this issue Feb 22, 2024 · 11 comments
Closed

Workflow failed: GraalVM native tests (#254) #10634

github-actions bot opened this issue Feb 22, 2024 · 11 comments
Assignees

Comments

@github-actions
Copy link
Contributor

See GraalVM native tests #254.

@laurit
Copy link
Contributor

laurit commented Feb 22, 2024

@jeanbisutti could you take a look. Could be because of #10607

@jeanbisutti jeanbisutti self-assigned this Feb 22, 2024
@jeanbisutti
Copy link
Member

It seems relatef to #10457

@jeanbisutti
Copy link
Member

The problem is related to #10457 using a SnakeYAML feature not working with GraalVM. The issue may be fixed with #10636 replacing the JAR-based resource extraction by a manifest-based resource extraction:

@jeanbisutti
Copy link
Member

The problem is related to #10457 using a SnakeYAML feature not working with GraalVM. The issue may be fixed with #10636 replacing the JAR-based resource extraction by a manifest-based resource extraction:

Or it may be fixed from #10621. @zeitlinger From which PR the manifest-based resource detection replaced the JAR-based one?

@zeitlinger
Copy link
Member

It will be fixed in #10636

Copy link
Contributor Author

See GraalVM native tests #255.

@jeanbisutti
Copy link
Member

I have just pushed on #10636. The GraalVM native tests have run successfully on my machine with this PR. @laurit @trask Could you please review this PR? So, the daily GraalVM native tests could be green again.

@trask
Copy link
Member

trask commented Feb 26, 2024

I have just pushed on #10636

is there reason not to send a separate PR to fix? generally faster for us to merge a standalone fix

@zeitlinger
Copy link
Member

zeitlinger commented Feb 27, 2024

I have just pushed on #10636

is there reason not to send a separate PR to fix? generally faster for us to merge a standalone fix

I've done that now: #10685

@jeanbisutti
Copy link
Member

jeanbisutti commented Feb 28, 2024

The problem is related to #10457 using a SnakeYAML feature not working with GraalVM. The issue may be fixed with #10636 replacing the JAR-based resource extraction by a manifest-based resource extraction:

As mentioned before, a problem is related to the SnakeYAML usage with GraalVM native. SnakeYAML is removed from the OpenTelemetry starter in #10636.

There is a second problem causing the failure of the OpenTelemetry starter native tests (introduced in #10602). The second problem can be fixed with 2d7254f:

@DisabledInNativeImage // Without this the native tests if the OtelSpringStarterSmokeTest class will
// fail with org.h2.jdbc.JdbcSQLSyntaxErrorException: Table "TEST_TABLE"
// already exists
class OtelSpringStarterDisabledSmokeTest {

@jeanbisutti
Copy link
Member

The GraalVM native tests are passing again on the main branch: https://github.com/open-telemetry/opentelemetry-java-instrumentation/actions/workflows/native-tests-daily.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants