Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogbackAppenderApplicationListener breaks spring boot startup if logback is not on your classpath #10784

Closed
jkwatson-verta opened this issue Mar 8, 2024 · 4 comments · Fixed by #10802
Labels
bug Something isn't working

Comments

@jkwatson-verta
Copy link

jkwatson-verta commented Mar 8, 2024

Describe the bug

If you use the instrumentation for spring-boot, but do not use spring-boot-starter-logging, but instead provide your own logging, that doesn't include logback, then this listener breaks spring-boot startup.

Steps to reproduce

Try to start up a spring-boot app that doesn't use logback. 💥

Expected behavior

Instrumentation should not break application startup.

Actual behavior

Spring boot will no longer start.

Javaagent or library instrumentation version

2.1.0-alpha

Environment

JDK: 21
OS: mac

Additional context

No response

@jkwatson-verta jkwatson-verta added bug Something isn't working needs triage New issue that requires triage labels Mar 8, 2024
@steverao
Copy link
Contributor

I used 2.1.0 version to test and don't reproduce the phenomenon mentioned above. I follow the way to test that by excluding spring-boot-starter-logging and adding spring-boot-starter-log4j2. Can you use the version to verify whether there is the same problem you mentioned above?

@steverao steverao added needs author feedback Waiting for additional feedback from the author and removed bug Something isn't working needs triage New issue that requires triage labels Mar 11, 2024
@jeanbisutti
Copy link
Member

Hi @steverao I think that it could have really a bug. Have you tried to display the dependency tree? Can you notice Logback dependencies on this tree?

@steverao
Copy link
Contributor

Hi @steverao I think that it could have really a bug. Have you tried to display the dependency tree? Can you notice Logback dependencies on this tree?

I didn't see logback relevant dependency in the tree. Do you reproduce same problem?
image

@laurit
Copy link
Contributor

laurit commented Mar 11, 2024

I tried it out an to me it looks the same as #10612

@laurit laurit added bug Something isn't working and removed needs author feedback Waiting for additional feedback from the author labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants