Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMQP message exception handling is not part of instrumentation #11545

Open
oldium opened this issue Jun 10, 2024 · 0 comments
Open

AMQP message exception handling is not part of instrumentation #11545

oldium opened this issue Jun 10, 2024 · 0 comments
Labels
bug Something isn't working needs triage New issue that requires triage

Comments

@oldium
Copy link

oldium commented Jun 10, 2024

Describe the bug

Currently the org.springframework.amqp.rabbit.listener.AbstractMessageListenerContainer::invokeListener(Channel, Object) is instrumented, which covers the message handling itself, but not the handling of exceptions raised by the message handler.

Steps to reproduce

Throw exception in @RabbitListener method and check the produced Execution of Rabbit message listener failed. log message.

Expected behavior

The log message Execution of Rabbit message listener failed. contains trace and span IDs.

Actual behavior

The log message does not contain trace nor span IDs.

Javaagent or library instrumentation version

v1.32.1

Environment

JDK: Temurin 17
OS: Debian 11 (bullseye)

Additional context

Used JAva instrumentation v1.32.1 from OpenTelemetry Kubernetes Operator v0.102.0.

I checked the code and it would be sufficient to instrument the org.springframework.amqp.rabbit.listener.AbstractMessageListenerContainer::executeListener(Channel, Object) instead of invokeListener to cover also the exception handling for the message.

@oldium oldium added bug Something isn't working needs triage New issue that requires triage labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New issue that requires triage
Projects
None yet
Development

No branches or pull requests

1 participant