Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring-boot-autoconfigure configuration and rename properties #2481

Closed
mateuszrzeszutek opened this issue Mar 3, 2021 · 2 comments
Closed
Assignees
Labels

Comments

@mateuszrzeszutek
Copy link
Member

Current spring-boot-autoconfigure configuration naming scheme is very different from what we use in SDK/javaagent: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/README.md#configuration-properties

Everything starts with opentelemetry.trace.*, some properties (like opentelemetry.trace.exporters.jaeger.servicename) do not exist anymore, there's even no way to configure the Resource.

We should use the same property names that we use in SDK or javaagent, e.g.:

  • otel.traces.* for tracer config;
  • otel.instrumentation.<name>.enabled to enable manual instrumentations (@WithSpan advice, HTTP clients, etc);
  • And add otel.resource.attributes support so that service.name is properly set.
@mateuszrzeszutek mateuszrzeszutek added bug Something isn't working cleanup labels Mar 3, 2021
@trask
Copy link
Member

trask commented Mar 3, 2021

there's also been some discussion in the past of transferring ownership of spring boot autoconfiguration to the spring cloud sleuth team / repo

@zeitlinger
Copy link
Member

Fixed by #10292

@zeitlinger zeitlinger self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants