Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable controller and view spans by default in 2.0 #9787

Closed
trask opened this issue Oct 31, 2023 · 5 comments · Fixed by #10042
Closed

Disable controller and view spans by default in 2.0 #9787

trask opened this issue Oct 31, 2023 · 5 comments · Fixed by #10042

Comments

@trask
Copy link
Member

trask commented Oct 31, 2023

Discussed in 10/26 SIG meeting, since there are no semantic conventions for controller, view, handler (etc) spans, it seems to make sense to make these opt-in.

Wondering if we should apply this to other INTERNAL spans, e.g. make hibernate instrumentation opt-in?

@trask trask changed the title Make controller and view spans opt-in in 2.0 Disable controller and view spans by default in 2.0 Nov 1, 2023
@heyams
Copy link
Contributor

heyams commented Dec 9, 2023

i would like to work on this next. can someone please assign it to me? thanks!

@heyams
Copy link
Contributor

heyams commented Dec 9, 2023

@trask/@mateuszrzeszutek what is the name of the system property for handler span?

@steverao
Copy link
Contributor

steverao commented Feb 26, 2024

Discussed in 10/26 SIG meeting, since there are no semantic conventions for controller, view, handler (etc) spans, it seems to make sense to make these opt-in.

Wondering if we should apply this to other INTERNAL spans, e.g. make hibernate instrumentation opt-in?

Hi Trask, making other instrumentations opt-in when they only produce internal spans, whether we have a final conclusion now?

@trask
Copy link
Member Author

trask commented Feb 27, 2024

I'm not sure if we have a super general recommendation at this point. Do you have a specific use case that we can discuss?

@steverao
Copy link
Contributor

steverao commented Feb 28, 2024

I'm not sure if we have a super general recommendation at this point. Do you have a specific use case that we can discuss?

In PR #10258, @laurit set it to disabled by default. He told me that later in Slack:

for 2.0 release, we disabled by default a bunch of instrumentations that don’t implement any semantic conventions and only produce internal spans. While there are still other instrumentations that do this and are enabled we may disable more of them in the future. We may revise this decision later and enable this or some of the currently disabled instrumentations by default.

When I saw the issue, so I want to know if there is a more formal decision on this problem? If there is a final decision, the plug-in can be implemented in accordance with the regulations in the future:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants