-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable controller and view spans by default in 2.0 #9787
Comments
i would like to work on this next. can someone please assign it to me? thanks! |
@trask/@mateuszrzeszutek what is the name of the system property for handler span? |
Hi Trask, making other instrumentations opt-in when they only produce internal spans, whether we have a final conclusion now? |
I'm not sure if we have a super general recommendation at this point. Do you have a specific use case that we can discuss? |
In PR #10258, @laurit set it to disabled by default. He told me that later in Slack:
When I saw the issue, so I want to know if there is a more formal decision on this problem? If there is a final decision, the plug-in can be implemented in accordance with the regulations in the future:) |
Discussed in 10/26 SIG meeting, since there are no semantic conventions for controller, view, handler (etc) spans, it seems to make sense to make these opt-in.
Wondering if we should apply this to other INTERNAL spans, e.g. make hibernate instrumentation opt-in?
The text was updated successfully, but these errors were encountered: