Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTel Demo] - Quote Service Metrics #2669

Closed
julianocosta89 opened this issue May 8, 2023 · 9 comments · Fixed by #4279
Closed

[OTel Demo] - Quote Service Metrics #2669

julianocosta89 opened this issue May 8, 2023 · 9 comments · Fixed by #4279
Assignees
Labels

Comments

@julianocosta89
Copy link
Member

This OTel Demo PR added metrics to the PHP service.
We need to add the process to the docs.

@julianocosta89 julianocosta89 added good first issue Good for newcomers demo labels May 8, 2023
@svrnm
Copy link
Member

svrnm commented May 10, 2023

thanks for raising this @julianocosta89 !

@svrnm svrnm added the sig:demo label Oct 18, 2023
@svrnm
Copy link
Member

svrnm commented Oct 18, 2023

@open-telemetry/demo-approvers @open-telemetry/php-approvers is this still relevant?

@svrnm svrnm added help wanted Extra attention is needed sig:php labels Oct 18, 2023
@julianocosta89
Copy link
Member Author

Yes, we need to update this section: https://opentelemetry.io/docs/demo/services/quote/#metrics

I can take care of this

@svrnm
Copy link
Member

svrnm commented Oct 18, 2023

thanks @julianocosta89

@kennykguo
Copy link

if this issue is still active, please assign this issue to me, thanks

@svrnm
Copy link
Member

svrnm commented Feb 20, 2024

hey @kennykguo, Please note that we are not assigning issues, as per our contribution guidelines, if you are interested to work on this issue let us know, and we keep track and wait for a PR from you. I recommend that you pick 1 or 2 issues you fill confident to provide a PR for within ~2 weeks.

@julianocosta89
Copy link
Member Author

@kennykguo feel free to take it, I've actually forgot to update it.
I was wrapping my head around it, as there is not much on metrics in the quoteservice other than those lines:
https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/quoteservice/public/index.php#L64-L68

I'm not sure how we could add that in the docs, but I'm open to suggestions.

@julianocosta89
Copy link
Member Author

@brettmc do you think we have something to add to the Metrics section of the PHP service in the docs?

Otherwise I'll just close this issue

@brettmc
Copy link
Contributor

brettmc commented Apr 11, 2024

do you think we have something to add to the Metrics section of the PHP service in the docs?

Yes, I've just submitted a PR to add some manual metrics to quote service (there are some auto-generated ones there already), then I'll update the Metrics and Logs sections of the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants