Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private projects disappear after screen name change in user profile #1650

Open
zfi opened this issue Feb 12, 2019 · 5 comments
Open

Private projects disappear after screen name change in user profile #1650

zfi opened this issue Feb 12, 2019 · 5 comments
Assignees

Comments

@zfi
Copy link
Contributor

zfi commented Feb 12, 2019

It appears that the simple act of changing the screen name in the user profile will cause the user's private project to become invisible. Returning the screen name in the user profile to the original screen name will restore access to the user's private projects.

@zfi zfi self-assigned this Feb 12, 2019
@zfi zfi added bug Priority 1 Server Server-side implementation issues labels Feb 12, 2019
@jeffam70
Copy link
Contributor

That sure is a surprise. Didn't think to test that one.

@zfi
Copy link
Contributor Author

zfi commented Feb 14, 2019

I was able to identify code in the UserService and UserDao layers that are using the Blockly user ID and screenname as a compound key to identify project ownership. When the user changes the screen name in their profile, it essentially removes the existing linkages to private projects. Working on an update that will remove the compound key.

@zfi
Copy link
Contributor Author

zfi commented Feb 20, 2019

This is also related to #1649 in that updating the screen name in the user profile was not updating the screen name in the blocklyprop user table. This then created a screen name mismatch, which broke the query that was listing the user's private projects based on a combination of the user id and the user's screen name.

@PropGit
Copy link
Contributor

PropGit commented May 24, 2019

Has anyone verified this is fixed?

@zfi
Copy link
Contributor Author

zfi commented May 24, 2019

The second update to this issue is not done. The immediate workaround was to simply disable the feature that supported changing a screen name in the user profile. We still need to add code to fix what is actually broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants