Subscription status not updated if admin reactivates a WooCommerce subscription

[rvdsteege]

While testing for #14, I discovered that a Pronamic subscription is not updated correctly and the status stays 'Cancelled' instead of 'Active' when an admin reactivates a WooCommerce subscription by changing the status from 'Pending cancellation' to 'Active'.

[rvdsteege]

The issue seems to be caused by hooking into the earlier save_post_shop_subscription action, instead of the later save_post action which is used by WooCommerce Subscriptions.

add_action( 'save_post', __CLASS__ . '::save_subscription_meta', 11 );

Source: https://github.com/pronamic/woocommerce-subscriptions/blob/50b02db3314ce937e9a670b4215fa4cced7652cf/vendor/woocommerce/subscriptions-core/includes/admin/class-wc-subscriptions-admin.php#L90