-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set the in_trash property of a page using notion.pages.update() #233
Comments
Hey @jeromegit, thanks for opening the issue! Indeed, we should add PR welcome! |
Hey @jeromegit @ramnes , thanks for your comments on this issue! https://github.com/digzect/notion-sdk-py/blob/6b1eb8f9972bb851fc6585aa80a184b397bfd2d5/notion_client/api_endpoints.py#L235 , and the |
Why removing Otherwise yes, just push your commit to a branch on your repository and open a PR! |
Thank you for your response.
The commit in question is specifically for the Given this information, how would you suggest we proceed? Should we keep only in_trash for the PagesEndpoint, or include both for maximum compatibility? |
I'd say let's take a look at notion-sdk-js and do whatever the Notion developers did there. :) |
I've looked at notion-sdk-js and using both |
Fixed in #236. Thanks! |
Hey @ramnes,
Thanks for the great module!
Adding
in_trash
to the list in the line referenced below should do the trick:notion-sdk-py/notion_client/api_endpoints.py
Line 235 in d5e5f5c
Merci !
The text was updated successfully, but these errors were encountered: