Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await iframes #630

Open
mfulton26 opened this issue Sep 23, 2022 · 1 comment
Open

await iframes #630

mfulton26 opened this issue Sep 23, 2022 · 1 comment

Comments

@mfulton26
Copy link

our team occasionally gets a different screenshot using storycap for pages that use an iframe

I see that storycap awaits various things including CSS; is there intentional support for awaiting iframes to load? if not, can such be added

thank you

@mfulton26 mfulton26 changed the title await iframe await iframes Sep 23, 2022
@yizumi1012xxx
Copy link

I encounter same problem, so I use --verbose option and check debug log.
I notice that storycap wait fetching resource that is used in iframe, but not wait iframe load.
I add play function for wait iframe load.
It work on local browser, but does not work on headless browser environment. (e.g. Github Action)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants