Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Upgrade to go 1.16 #1

Closed
jiping-s opened this issue Jun 3, 2021 · 1 comment
Closed

all: Upgrade to go 1.16 #1

jiping-s opened this issue Jun 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jiping-s
Copy link
Collaborator

jiping-s commented Jun 3, 2021

go 1.16 should offer significant performance improvement in the scheduler when GOMAXPROCS is high (e.g. 1000), due to partial addressing of golang/go#28808

What need to be done:

  • Running benchmarks with fixed GOMAXPROCS=12 against different inputs to make sure there is no slowdown
  • Running benchmarks with GOMAXPROCS=1000 against different inputs to make sure there is no slowdown
  • Running benchmarks with default GOMAXPROCS on a server with at least 500 cores to make sure there is no slowdown
  • Try different defs.IntermediateBufferedChannelSize values to see if it should be changed.

Input log types:

  • Common log records with around 200 bytes for each record, including syslog headers
  • Huge log records for error dumps, 10-50K. The new errors-input.log may be good enough for this.
@jiping-s jiping-s added the enhancement New feature or request label Jun 3, 2021
@jiping-s jiping-s changed the title Upgrade to go 1.16 all: Upgrade to go 1.16 Jun 3, 2021
@jiping-s
Copy link
Collaborator Author

Verified, no visible improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant