Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roborock: Add WiFi signal strength sensor #1918

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SLaks
Copy link
Contributor

@SLaks SLaks commented Mar 20, 2024

Re: #1914 (comment)

All I have is Q Revo and S7 (both cloud connected); I don't know about other devices.

Options include:

  • Store prior info() failures and skip this if it fails
  • Only call add_update_method(connectivity_status) if the WiFi strength sensor is enabled in HA (requires a more complex refactor)
  • Move this sensor to a separate feature in the base class, independent of status classes and everything else (would decouple async work, and may make it easier to implement the previous bullet)

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (8643a57) to head (fd973a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1918      +/-   ##
==========================================
+ Coverage   81.41%   81.42%   +0.01%     
==========================================
  Files         193      193              
  Lines       18636    18648      +12     
  Branches     4045     4049       +4     
==========================================
+ Hits        15173    15185      +12     
  Misses       3180     3180              
  Partials      283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I plan to use this to draw a WiFi signal strength map of my house
@SLaks
Copy link
Contributor Author

SLaks commented Mar 20, 2024

Update: As I ran the vacuum, this sensor never changed.

I'm not sure whether that means my implementation is incorrectly caching, or whether the vacuum reports stale data.

@SLaks
Copy link
Contributor Author

SLaks commented Mar 20, 2024

I tried using https://github.com/marcelrv/XiaomiRobotVacuumProtocol/blob/master/network_info.md instead, and watched it print the same value in the terminal as the vacuum moved halfway across the house.

Either my WiFi coverage is literally perfect (which seems very unlikely) or the vacuum doesn't actually make this possible.

Confusingly, my S7 reports 0, even after rebooting somewhere else.

@SLaks SLaks marked this pull request as draft March 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant