Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let us join efforts (xrpl_async-rs) #50

Open
vporton opened this issue Feb 27, 2023 · 1 comment
Open

Let us join efforts (xrpl_async-rs) #50

vporton opened this issue Feb 27, 2023 · 1 comment

Comments

@vporton
Copy link

vporton commented Feb 27, 2023

I am writing xrpl_async Rust library.

I implemented a good async interface common for both JSON RPC and WebSocket APIs. I also implemented some WebSocket waiter tweaks. Thus your task of "Asynchronous ledger interactions" and is to be counted done.

Also I create "Models" instead of you.

I import your library for {decode,encode}_base58.

I propose to join efforts: xrpl-rust for low-level stuff and xrpl_async for high-level. Agree?

I am now trying to serialize transactions. Ideally it would be like this:

#[derive(Serialized)]
struct Transaction {
    #[serialized_as(nth = ...)] // The rest serialization properties belong to `Address` type
    account: Address,
    // ...
}

Then the Rust macro implementation can sort fields to correct order.

Your serialization seems to use string representations of types, what is not idiomatic Rust. I am now thinking about creating such macro wrapper around your serialization functions. Please, give me a clue: What is the most high-level way to serialize with xrpl-rust? (I think it's the one described here, but I am unsure if it's the highest level of your library, by the way it uses string representations of types, what is not idiomatic Rust.)

So, how will we collaborate?

@LimpidCrypto
Copy link
Collaborator

LimpidCrypto commented Feb 27, 2023

We are always open to collaborate. Please take a look at our development branch and checkout our milestones we want to achieve due the XRPL Grants program. We might also formulate some bounties for some tasks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants