Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize thiserror and anyhow for Error handling #53

Open
LimpidCrypto opened this issue Mar 10, 2023 · 1 comment
Open

Utilize thiserror and anyhow for Error handling #53

LimpidCrypto opened this issue Mar 10, 2023 · 1 comment
Assignees
@LimpidCrypto
Labels
1st month Planned to be worked on in the first month. Estimate budget: 13,333 $ enhancement New feature or request XRPL Grants This issue is planned to get resoled as part of the XRPL Grants program (within 8 months)
Milestone
Improve error han...

Comments

@LimpidCrypto
Copy link
Collaborator

Utilize modern error handling:

thiserror:
https://docs.rs/thiserror/latest/thiserror/
https://crates.io/crates/thiserror/1.0.24

anyhow:
https://docs.rs/anyhow/latest/anyhow/
https://crates.io/crates/anyhow

This has to be implemented for existing errors and has to be done for all future errors
@LimpidCrypto LimpidCrypto self-assigned this Mar 10, 2023
@LimpidCrypto LimpidCrypto added the 1st month Planned to be worked on in the first month. Estimate budget: 13,333 $ label Mar 10, 2023
@LimpidCrypto LimpidCrypto added this to the Improve error handling milestone Mar 10, 2023
@LimpidCrypto LimpidCrypto added enhancement New feature or request XRPL Grants This issue is planned to get resoled as part of the XRPL Grants program (within 8 months) labels Mar 10, 2023
@LimpidCrypto LimpidCrypto mentioned this issue Mar 11, 2023
Merged
@LimpidCrypto
Copy link
Collaborator Author

We already have utilized anyhow and thiserror for the models. We still have to utilize them for core, utils and wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LimpidCrypto LimpidCrypto

Labels
1st month Planned to be worked on in the first month. Estimate budget: 13,333 $ enhancement New feature or request XRPL Grants This issue is planned to get resoled as part of the XRPL Grants program (within 8 months)
Projects
xrpl-rust
Status: 🏗 In progress
Milestone
Improve error handling
Development

No branches or pull requests
1 participant
@LimpidCrypto