New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the service be aware of the implementation of the repository? #1

Open

Terminator637 opened this issue Dec 5, 2018 · 1 comment

Terminator637 commented Dec 5, 2018

I think that the service should not know or guess that the repository is a SQL database.

gokit-examples/services/order/implementation/service.go

Line 51 in 0f59bdb

if err == sql.ErrNoRows {

architgupta13 commented Aug 29, 2020

Good point. I think it could've been better wrapped in a custom error handler to help distinguish repository errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment