Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited view properties are not correctly assigned on some components #567

Open
cayleyh opened this issue Jan 5, 2021 · 0 comments
Open

Comments

@cayleyh
Copy link

cayleyh commented Jan 5, 2021

Inherited view props such as testID and accessibilityLabel are not being correctly passed along to the underlying component in some cases.

For example, the Spinner component does not do this, so code like this:

<Spinner accessibilityLabel="Loading" />

Does not add the accessibilityLabel prop to the underlying ActivityIndicator instance.

This is going to be an issue for basically any component that doesn't pass along all the properties to the underlying objects.

I didn't check too deeply, but there seems to be a mix. The simple components like Button that just defer to the underlying RN implementation seem to mostly do this correctly. Maybe Spinner was just missed.

The more complex components do not do any of this, but it's not clear with my limited understanding of the code base how these general properties should be applied from a top level, particularly with the accessibility ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant