Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 URL is wrong in sorry-cypress dashboard #224

Open
3 tasks done
thowd22 opened this issue Jul 6, 2023 · 5 comments
Open
3 tasks done

s3 URL is wrong in sorry-cypress dashboard #224

thowd22 opened this issue Jul 6, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@thowd22
Copy link

thowd22 commented Jul 6, 2023

Before opening, please confirm:

Environment information

  - sorry-cypress version: `latest`
  - cypress version: `latest`
  - cy2 version: `latest`
  - platform: `k8s`
  - service: `dashboard`

Describe the bug

It seems like the url for viewing screenshots is hard-coded in sorry-cypress dashboard. We are uploading to an s3 bucket in gov cloud and the url is incorrect for viewing the screenshots.

This is the correct bucket url: https://company-cypress-tests.s3-us-gov-east-1.amazonaws.com
This is the url in the dashboard: https://company-cypress-tests.s3.amazonaws.com

Maybe its an issue with the s3 driver?

Expected behavior

Screenshots are viewable in the dashboard.

Reproduction steps

Set region: us-gov-east-1 in the sorry-cypress helm chart.

Full log and debug output

// Put your logs below this line


@thowd22 thowd22 added the bug Something isn't working label Jul 6, 2023
@agoldis agoldis self-assigned this Jul 6, 2023
@agoldis
Copy link
Contributor

agoldis commented Jul 6, 2023

@thowd22
Copy link
Author

thowd22 commented Jul 6, 2023

Do I change that option in the chart to? Will it change the url for previous builds?

readUrlPrefix: "company-cypress-tests.s3-us-gov-east-1.amazonaws.com"

@agoldis
Copy link
Contributor

agoldis commented Jul 9, 2023

@thowd22 not sure - maybe @fbritoferreira can help

@fbritoferreira
Copy link
Contributor

@thowd22 Are you using the chart? If so can you please share your config

@fbritoferreira fbritoferreira transferred this issue from sorry-cypress/sorry-cypress Jul 12, 2023
@chrishollandaise
Copy link

From testing, changing the readUrlPrefix will not be reflected in previous builds. If it pointed to the wrong resource, it will won't change after proper configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants