Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log leftover actor ids when shutting down #4267

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobim
Copy link
Member

@tobim tobim commented Jun 3, 2024

This is an experimental change to the actor system registry in CAF. Instead of maintaining a simple running actor counter, it now keeps all ids of the running actors. This change should allow us to debug actor termination problems.

@tobim tobim added the bug Incorrect behavior label Jun 3, 2024
TENZIR_VERBOSE("remaining actors: [{}], named: [{}]",
fmt::join(sys.registry().running_ids(), ", "),
fmt::join(sys.registry().named_actors(), ", "));
std::this_thread::sleep_for(std::chrono::seconds(2));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the sleep actively harmful here? If we enter this loop at least once (which is likely) then the shutdown in the correct case takes another two seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
2 participants