Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add annotation linting #10

Open
charlesfrye opened this issue Jul 7, 2022 · 1 comment
Open

add annotation linting #10

charlesfrye opened this issue Jul 7, 2022 · 1 comment

Comments

@charlesfrye
Copy link
Collaborator

command:

python -m flake8 --select=ANN --ignore=ANN101,ANN102,ANN002,ANN003,ANN202 \
--mypy-init-return --suppress-none-returning ./text-recognizer ./training

currently 228 lints

@charlesfrye
Copy link
Collaborator Author

copied from https://github.com/full-stack-deep-learning/fsdl-text-recognizer-2021/issues/74, the process for adding a new linting tool

because this uses flake8 and it's already installed in dev-lint, we just need to change the configuration to get it to lint in pre-commit and to run locally

Process:

  • add to pre-commit
  • lint all files
  • add to dev-lint environment
  • run locally
  • add to tasks/lint.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant